Add identity node to removal list #137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rn new rounding modes.
Fixed rounding_mode specifier in convert_quantized_bits
Commented out assertion on non-representability
…ay_and_auto_po2_scale Merging changes from rounding_mode_new.
…nto HEAD Merge changes from the new converter
|
I've cherry picked the commit 3eddb38 making the key changes for this PR and merged as part of #87. Thanks @jurevreca12 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
RemoveIdentityOpsin src/qonnx/transformation/remove.py to also remove onnx.Identity nodes. These nodes are left in the onnx graph by the QKeras-to-ONNX converter. However they are defined essentially as "passthrough" nodes, that do not perform any computation but just forward the tensor along.This PR follows PR: Is tensor representable #136. After it is merged into main the only change will be additional 4 lines in remove.py.